palantir/blueprint

[V5] ContextMenu does not lazy render popover anymoe

Open

#6171 opened on May 23, 2023

View on GitHub
 (4 comments) (1 reaction) (0 assignees)TypeScript (20,263 stars) (2,167 forks)batch import
P2Package: coreType: bughelp wanted

Description

Environment

  • Package version(s): 5.0.0-alpha.3
  • Operating System: MacOS
  • Browser name and version: Chrome

Steps to reproduce

  • We're migrating ContextMenu2 --> ContextMenu, but see some degrade in performance for some of our table.

Actual behavior

  • Lots of portal divs are created in advance, this is not happening with ContextMenu2, it used to be lazy, 2023-05-24-001917_611x460_scrot

  • I am trying to pass lazy: true to popoverProps but TypeScript complaining, apparently because we only pick a handful of props.

Expected behavior

  • lazy should be the default, like it was with ContextMenu2

Possible solution

I'm not too sure this time...

Contributor guide

Tech stack
typescriptreact
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
ReactTypeScriptBlueprint components
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
35
Research direction
Investigate the ContextMenu component source in the Blueprint repository (e.g., src/components/context menu/contextMenu.tsx). Compare with the deprecated ContextMenu2 to understand how lazy rendering was implemented before. Check the Popover component's lazy prop and why it's not exposed. Look at recent comments for maintainer suggestions. Possibly submit a PR to make lazy default or add the prop back.