palantir/blueprint

HACKHACK: datetime tests skipped in key code refactor

Open

#6109 opened on May 2, 2023

View on GitHub
 (1 comment) (0 reactions) (0 assignees)TypeScript (20,263 stars) (2,167 forks)batch import
Domain: testingP2Package: datetimehelp wanted

Description

Skipped while migrating from event.which / event.keyCode -> event.key in https://github.com/palantir/blueprint/pull/6106

The functionality seems to work fine in the docs example:

2023-05-02 11 29 43

Contributor guide

Tech stack
typescriptreactjest
Domain
frontendtesting
Issue type
test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
TypeScriptReact testingevent.key migration
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Review PR #6106 to understand the migration from `event.which` to `event.key`. Locate the skipped datetime tests and examine the docs example for expected behavior. Write tests that verify the key event handling for datetime components, ensuring they pass.