palantir/blueprint

HACKHACK: datetime tests skipped in key code refactor

Open

#6,109 opened on May 2, 2023

View on GitHub
 (1 comment) (0 reactions) (0 assignees)TypeScript (2,167 forks)batch import
Domain: testingP2Package: datetimehelp wanted

Repository metrics

Stars
 (20,263 stars)
PR merge metrics
 (Avg merge 43d 10h) (27 merged PRs in 30d)

Description

Skipped while migrating from event.which / event.keyCode -> event.key in https://github.com/palantir/blueprint/pull/6106

The functionality seems to work fine in the docs example:

2023-05-02 11 29 43

Contributor guide

Research direction
Find the skipped datetime tests in the repository, understand the migration from event.which/event.keyCode to event.key, and ensure the tests pass by unskipping them or fixing any failing assertions.
Tech stack
typescriptreact
Domain
frontend
Issue type
Test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitTypeScriptReact
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80