palantir/blueprint

Vertical Misalignment when NumericInput is wrapped in a Label (visual bug)

Open

#6030 opened on Mar 17, 2023

View on GitHub
 (1 comment) (0 reactions) (0 assignees)TypeScript (20,263 stars) (2,167 forks)batch import
P2Package: coreType: bughelp wanted

Description

Environment

  • Package version(s): 4.17.6
  • Operating System: MacOS Ventura
  • Browser name and version: Chrome version 111.0.5563.64

Code Sandbox

Link to a minimal repro: Sandbox

Steps to reproduce

  1. Visual bug (appearance)

Actual behavior

Placing NumericInput inside Label causes vertical misalignment of the text input as there is an additional 5px top margin on the text input.

Expected behavior

The text inputs and button inputs should be vertically aligned.

Possible solution

Add CSS property to default the margin-top to 0 on the text input for NumericInput so that even if it is wrapped in a Label there aren't additional margins.

Contributor guide

Tech stack
typescriptreactcss
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
CSSReact components
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90
Research direction
The issue reports a vertical misalignment when NumericInput is wrapped in a Label. The suggested fix is to add CSS property `margin top: 0` to the text input in NumericInput. The developer should locate the CSS file for NumericInput (likely in the Blueprint source under `packages/select/src/` or similar) and add the rule. Verify that the fix doesn't break other use cases where NumericInput is not wrapped in a Label. The issue has no linked PRs or assignees, so it's open for contribution.