palantir/blueprint

`Table2` column header does not re-render correctly on size change

Open

#5,936 opened on Feb 10, 2023

View on GitHub
 (3 comments) (0 reactions) (0 assignees)TypeScript (2,167 forks)batch import
P2Package: tableType: bughelp wanted

Repository metrics

Stars
 (20,263 stars)
PR merge metrics
 (Avg merge 43d 10h) (27 merged PRs in 30d)

Description

Code Sandbox

Link to a minimal repro (fork this code sandbox): https://codesandbox.io/s/gallant-tree-hch623?file=/src/index.tsx

Steps to reproduce

  1. create a basic Table2 with columnHeaderCellRenderer that changes its height depending on some state
  2. update state and observe that the header size is not re-rendered correctly

(even if the dependency's added to the cellRendererDependencies prop)

Actual behavior

Columns header changes its height, but does not reposition any other row or columns.

Expected behavior

Should reposition all cells / headers upon size change.

Possible solution

TBD

Contributor guide

Research direction
Investigate how Table2 column headers are rendered and why size changes do not trigger re render of other cells. Check the columnHeaderCellRenderer and cellRendererDependencies props to see if the component updates properly.
Tech stack
typescriptreact
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
ReactTypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65