palantir/blueprint

`Table2` column header does not re-render correctly on size change

Open

#5936 opened on Feb 10, 2023

View on GitHub
 (3 comments) (0 reactions) (0 assignees)TypeScript (20,263 stars) (2,167 forks)batch import
P2Package: tableType: bughelp wanted

Description

Code Sandbox

Link to a minimal repro (fork this code sandbox): https://codesandbox.io/s/gallant-tree-hch623?file=/src/index.tsx

Steps to reproduce

  1. create a basic Table2 with columnHeaderCellRenderer that changes its height depending on some state
  2. update state and observe that the header size is not re-rendered correctly

(even if the dependency's added to the cellRendererDependencies prop)

Actual behavior

Columns header changes its height, but does not reposition any other row or columns.

Expected behavior

Should reposition all cells / headers upon size change.

Possible solution

TBD

Contributor guide

Tech stack
reacttypescript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
ReactTypeScriptBlueprint Table2 API
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Investigate the Table2 component's re render logic, focusing on how column headers are updated when the cellRendererDependencies change. Check the source code in the 'packages/table' directory, specifically the code for column header rendering. Look for any missing calls to update layout or trigger re render. Consider testing the provided code sandbox to reproduce the issue.