palantir/blueprint

Popover2 caret does not align with center of small target (e.g., Icon)

Open

#5924 opened on Feb 6, 2023

View on GitHub
 (3 comments) (0 reactions) (0 assignees)TypeScript (20,263 stars) (2,167 forks)batch import
P2Package: popover2Type: bughelp wanted

Description

Environment

  • Package version(s): @blueprintjs/popover2 1.9.0
  • Operating System: macOs Monterey
  • Browser name and version: Chrome 109

Code Sandbox

Link to a minimal repro (fork this code sandbox): sandbox

Steps to reproduce

  1. Create a popover with Popover2 whose target is just an icon.
  2. Set the placement to anything *-start or *-end.

Actual behavior

The popover caret is not aligned with the center of the icon target.

Expected behavior

The popover should point to the center of the icon target, although I'm not sure how to respect the -start or -end requirement simultaneously. In the screenshot above, the problem is that the popover content is aligned to the left side of the icon, but then the width of the caret plus the small margin to the left of the caret is wider than the target icon itself.

Possible solution

Possibly consumers just need to use some css or popover modifiers to align the popover with small targets as they wish, but this use case seems common enough to be worth flagging; also, I'm not 100% sure, but I think this is a break with Popover behavior.

Contributor guide

Tech stack
typescriptreactcss
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
CSSReact
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Investigate the positioning logic in the Popover2 component, specifically how the caret offset is calculated relative to the target element. The issue occurs when the target is small (e.g., Icon). Look at the CSS styles for popover caret and the alignment mechanism. Consider modifying the caret's left/right offset or using a different alignment strategy for small targets. Review the code responsible for the `placement` prop with ` start` and ` end` values.