palantir/blueprint

Mouse Event onChange Slider

Open

#5916 opened on Feb 1, 2023

View on GitHub
 (1 comment) (0 reactions) (0 assignees)TypeScript (20,263 stars) (2,167 forks)batch import
P2Package: coreType: feature requesthelp wanted

Description

Improve Slider in Blueprint

Slider onChange does not have mouse event as a return value. Would be nice to add it, cause we cannot stop the propagation of the event.

Current: onChange={(value) => console.log(value); }

Expected: onChange={(value, e) => console.log(value); e.stopPropagation()}

Contributor guide

Tech stack
typescriptreact
Domain
frontend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic knowledge of ReactFamiliarity with TypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80
Research direction
Look at the Blueprint Slider component implementation. The onChange callback currently only passes the value. The change involves adding an event parameter (type React.SyntheticEvent) to the callback signature and propagating it from the internal handlers. Check the Slider's source files, likely in src/components/slider, and update the type definitions and tests accordingly.