palantir/blueprint

Overlay enforcing focus not returning focus to the last focused element in the overlay

Open

#5857 opened on Jan 20, 2023

View on GitHub
 (1 comment) (0 reactions) (0 assignees)TypeScript (20,263 stars) (2,167 forks)batch import
P3Package: coreType: bughelp wanted

Description

Environment

  • Package version(s): 8.5.5
  • Operating System: macOS Ventura 13.1 (22C65)
  • Browser name and version: Version 109.0.5414.87 (Official Build) (arm64)

Code Sandbox

Link to a minimal repro (fork this code sandbox): https://codesandbox.io/s/exciting-greider-3u7620

Steps to reproduce

  1. Start typing in the overlay's input box.
  2. Wait 2 seconds.
  3. Notice how the focus is not returned to the input box but instead to the overlay's root element.

Expected behavior

I'd expect the focus to be returned to the last focused element in the overlay. Otherwise, it's particularly problematic for omnibars.

Contributor guide

Tech stack
typescriptreact
Domain
frontendaccessibility
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
ReactTypeScriptDOM focus API
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45
Research direction
Investigate the Overlay component's focus management logic in the source code (likely in packages/core/src/components/overlay). Understand how the component saves and restores focus. Verify that the last focused element is correctly tracked before the overlay appears. Consider adding a test that simulates the user's behavior. The issue mentions a sandbox, so you can reproduce the problem there.