palantir/blueprint

Table2 truncated table cells not vertically centered with non-default table row heights

Open

#5767 opened on Nov 21, 2022

View on GitHub
 (1 comment) (0 reactions) (0 assignees)TypeScript (20,263 stars) (2,167 forks)batch import
P2Package: tableType: bughelp wanted

Description

Steps to reproduce

  1. Create a table with non-default row heights, in my screenshot below this is 30px via defaultRowHeight={30}
  2. Add cells formatted with <TruncatedFormat2 />

Actual behavior

The row contents are not all vertically lined up

Expected behavior

Row contents are still vertically centered within the row.

Possible solution

TruncatedFormat2 does some relative styling for the truncated value + truncated-more-button. It could instead be flex-styled to right align the more-button.

Contributor guide

Tech stack
typescriptreactcss
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic ReactCSS flexboxunderstanding of TruncatedFormat2 component
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Examine the TruncatedFormat2 component in the blueprint source code (likely in packages/table/src/cell/truncatedFormat2.tsx). Investigate how it handles vertical alignment within table cells when row height is set via defaultRowHeight. Look for CSS styling that might be interfering with vertical centering. Consider modifying the component to use flexbox for alignment as suggested.