palantir/blueprint

Modifying the time doesn't show up on the timepicker in DateRangePicker

Open

#5,502 opened on Aug 22, 2022

View on GitHub
 (1 comment) (0 reactions) (0 assignees)TypeScript (2,167 forks)batch import
P2Package: datetimeType: bughelp wanted

Repository metrics

Stars
 (20,263 stars)
PR merge metrics
 (Avg merge 43d 10h) (27 merged PRs in 30d)

Description

Environment

  • Package version(s): 4.3.4
  • Operating System: MacOS Monterey
  • Browser name and version: Firefox 103.0.2

Code Sandbox

Link to a minimal repro: https://codesandbox.io/s/blueprint-sandbox-forked-gb14b7

Steps to reproduce

  1. Select two dates in the daterangepicker

Actual behavior

Modifying the endTime (from 00:00 to 23:59) doesn't show the modified end time in the time picker. (I modify the time in the onChange)

Expected behavior

When I change the time on the endDate value, it should update on the DateRangePicker end time

Possible solution

It looks like it doesn't update the startTime or endTime in the code when the props change, only on the construction. Modify it so it does do that.

Contributor guide

Research direction
Inspect the DateRangePicker component's state initialization and update logic for startTime and endTime. The issue suggests that modifying the endTime via onChange does not reflect in the time picker. Look at the component's constructor or getDerivedStateFromProps to see if startTime/endTime are only set on mount. A possible fix is to use componentDidUpdate or useEffect to sync the controlled value with internal state when props change.
Tech stack
typescriptreact
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
ReactGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70