palantir/blueprint

Modifying the time doesn't show up on the timepicker in DateRangePicker

Open

#5502 opened on Aug 22, 2022

View on GitHub
 (1 comment) (0 reactions) (0 assignees)TypeScript (20,263 stars) (2,167 forks)batch import
P2Package: datetimeType: bughelp wanted

Description

Environment

  • Package version(s): 4.3.4
  • Operating System: MacOS Monterey
  • Browser name and version: Firefox 103.0.2

Code Sandbox

Link to a minimal repro: https://codesandbox.io/s/blueprint-sandbox-forked-gb14b7

Steps to reproduce

  1. Select two dates in the daterangepicker

Actual behavior

Modifying the endTime (from 00:00 to 23:59) doesn't show the modified end time in the time picker. (I modify the time in the onChange)

Expected behavior

When I change the time on the endDate value, it should update on the DateRangePicker end time

Possible solution

It looks like it doesn't update the startTime or endTime in the code when the props change, only on the construction. Modify it so it does do that.

Contributor guide

Tech stack
typescriptreact
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
React state managementBlueprint component API
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
Investigate the DateRangePicker component source code, specifically the handling of startTime and endTime props. Look at the constructor and componentDidUpdate methods in src/components/date range picker/dateRangePicker.tsx to see why time changes do not propagate. Check if the component re renders correctly when props change and consider adding a componentDidUpdate or getDerivedStateFromProps to sync state.