palantir/blueprint

[MultiSelect2 / TagInput] Deleting tags is performed in the wrong order after deleting

Open

#5412 opened on Jul 5, 2022

View on GitHub
 (2 comments) (0 reactions) (0 assignees)TypeScript (20,263 stars) (2,167 forks)batch import
P3Package: corePackage: selectType: bughelp wanted

Description

Environment

  • Package version(s): @blueprintjs/core v4.5.1
  • Operating System: macOS Monterey
  • Browser name and version: Google chrome 103.0.5060.53 (Build officiel) (x86_64),

Code Sandbox

Example

Steps to reproduce

  1. Create an app using tagInput or MultiSelect
  2. Add one or multiple tags
  3. Delete all
  4. Add tags agains
  5. Delete them (should goes in the wrong order)

Actual behavior

Using keyboard Backspace, after deleting all existing tags in a tagInput, when you try to add new one, the first added take "focus" or become active, and if you have more tags after it still this tag that will be delete first. You can still use keyboard "left" and "right" to change active tag.

Here is a short video :

https://user-images.githubusercontent.com/9548473/177285272-56e1b317-1229-4603-a666-63290ead1649.mov

Expected behavior

Delete operation always start from the tag closest to the cursor by default.

Contributor guide

Tech stack
typescriptreact
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Familiarity with ReactUnderstanding of Blueprint's TagInput
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
The bug is in the keyboard navigation logic for TagInput and MultiSelect2 components, specifically when deleting tags via Backspace. After deleting all tags, the internal state for the active (focused) tag is not reset, causing subsequent additions to have an incorrect active tag. Investigate the `handleDelete` and `handleKeyDown` methods in the TagInput component source code (likely `packages/core/src/components/tag input/tagInput.tsx`). Check how the `activeIndex` state is managed after deletion and ensure it resets to the last tag or is cleared appropriately.