palantir/blueprint

Locale = English does not display comma separators

Open

#5,405 opened on Jun 28, 2022

View on GitHub
 (5 comments) (0 reactions) (0 assignees)TypeScript (2,167 forks)batch import
P2Package: coreType: feature requesthelp wanted

Repository metrics

Stars
 (20,263 stars)
PR merge metrics
 (Avg merge 43d 10h) (27 merged PRs in 30d)

Description

https://blueprintjs.com/docs/#core/components/numeric-input Typing "1000000" with locale set to English does not convert the display format to "1,000,000", contrary to https://github.com/palantir/blueprint/blob/develop/packages/docs-app/src/examples/core-examples/common/locales.tsx#L20

Contributor guide

Research direction
Inspect the NumericInput component's locale handling, trace how the value is formatted, and compare with the locale configuration in locales.tsx.
Tech stack
typescriptreact
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitTypeScriptReact
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75