palantir/blueprint

Locale = English does not display comma separators

Open

#5405 opened on Jun 28, 2022

View on GitHub
 (5 comments) (0 reactions) (0 assignees)TypeScript (20,263 stars) (2,167 forks)batch import
P2Package: coreType: feature requesthelp wanted

Description

https://blueprintjs.com/docs/#core/components/numeric-input Typing "1000000" with locale set to English does not convert the display format to "1,000,000", contrary to https://github.com/palantir/blueprint/blob/develop/packages/docs-app/src/examples/core-examples/common/locales.tsx#L20

Contributor guide

Tech stack
typescriptreact
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Familiarity with Blueprint's NumericInput componentBasic understanding of JavaScript Intl.NumberFormat
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75
Research direction
Examine the locale.tsx file (packages/docs app/src/examples/core examples/common/locales.tsx) to understand the locale configuration. Then review the NumericInput component implementation, likely in packages/core/src/components/numeric input, to see how number formatting is applied. Check if Intl.NumberFormat is used and whether the issue is due to missing options for grouping separators. Also look at the comments on the issue for any additional context or hints from maintainers. If possible, test the behavior with different locales.