palantir/blueprint

[webpack-build-scripts] asset file name generator is missing query delimiter

Open

#5296 opened on May 10, 2022

View on GitHub
 (0 comments) (0 reactions) (0 assignees)TypeScript (20,263 stars) (2,167 forks)batch import
Domain: toolingP2Type: bughelp wanted

Description

Environment

  • Package version(s): @blueprintjs/webpack-build-scripts v3.2.1
  • Browser: Chrome

Actual behavior

When using webpack-build-scripts' base config outside this repo, asset files like SVGs are being generated in the bundle with paths like assets/logo-black.svgccef1ff6a39afed7ae4a, which prevent browsers like Chrome from interpreting them according to their file extension.

Expected behavior

The file extension should be preserved in these webpack asset URLs

Possible solution

Add a ? in the file name generator

Contributor guide

Tech stack
typescriptreact
Domain
build systemtooling
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaScriptwebpack
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85
Research direction
Locate the webpack configuration file in the @blueprintjs/webpack build scripts package. Look for the file name generator configuration, likely in a file like `webpack.base.js` or similar. Add a '?' delimiter between the base name and the hash to ensure the file extension is preserved. Verify by running the build and checking that asset paths contain a '?' before the hash.