palantir/blueprint

[node-build-scripts] es-lint path logic is broken

Open

#5,295 opened on May 10, 2022

View on GitHub
 (0 comments) (0 reactions) (0 assignees)TypeScript (2,167 forks)batch import
Domain: toolingP2Type: bughelp wanted

Repository metrics

Stars
 (20,263 stars)
PR merge metrics
 (Avg merge 43d 10h) (27 merged PRs in 30d)

Description

similar to https://github.com/palantir/blueprint/issues/4942

Environment

  • Package version(s): node-build-scripts v2.0.x

Steps to reproduce

use es-lint script outside this repo, in CircleCI where JUNIT_REPORT_PATH variable is present in the environment

Actual behavior

the utility function junitReportPath() returns a path within node_modules/reports/, which is wrong

Expected behavior

The script is usable outside this repo

Possible solution

Use process.cwd() instead of __dirname

Contributor guide

Research direction
Replace ` dirname` with `process.cwd()` in the `junitReportPath()` function.
Tech stack
typescriptnodejs
Domain
build systemdeveloper experience
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Node.js
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80