palantir/blueprint

[node-build-scripts] es-lint path logic is broken

Open

#5295 opened on May 10, 2022

View on GitHub
 (0 comments) (0 reactions) (0 assignees)TypeScript (20,263 stars) (2,167 forks)batch import
Domain: toolingP2Type: bughelp wanted

Description

similar to https://github.com/palantir/blueprint/issues/4942

Environment

  • Package version(s): node-build-scripts v2.0.x

Steps to reproduce

use es-lint script outside this repo, in CircleCI where JUNIT_REPORT_PATH variable is present in the environment

Actual behavior

the utility function junitReportPath() returns a path within node_modules/reports/, which is wrong

Expected behavior

The script is usable outside this repo

Possible solution

Use process.cwd() instead of __dirname

Contributor guide

Tech stack
typescriptnodejs
Domain
build system
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic knowledge of Node.jsunderstanding of dirname and process.cwd
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85
Research direction
The fix is to replace dirname with process.cwd() in the junitReportPath() function. Locate the file containing this function within the node build scripts package. Ensure the change applies only when running outside the repo; consider adding a test if applicable.