palantir/blueprint

[FormGroup] Using both `inline` and `subLabel` props produce misaligned `subLabel`s

Open

#5294 opened on May 9, 2022

View on GitHub
 (0 comments) (0 reactions) (0 assignees)TypeScript (20,263 stars) (2,167 forks)batch import
P2Package: coreType: bughelp wanted

Description

Environment

  • Package version(s): @blueprintjs/core 4.3.0

Steps to reproduce

  1. Use a FormGroup with both inline and subLabel props.
<FormGroup
    inline={true}
    label="Label"
    labelFor="text-input"
    labelInfo="(required)"
    subLabel="Label helper text with details..."
>
    <InputGroup id="text-input" placeholder="Placeholder text" />
</FormGroup>

Actual behavior

Screenshot from the docs example page:

image

Expected behavior

The subLabel appears aligned with something, so either:

  • The subLabel appears below the label/labelInfo?
  • The subLabel appears above the input?

Contributor guide

Tech stack
typescriptreactcss
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
React basicsCSSBlueprint FormGroup component
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
The issue is about misaligned subLabel in FormGroup when both inline and subLabel props are used. Start by examining the FormGroup component source code in the Blueprint repository, likely in `packages/core/src/components/forms/formGroup.tsx`. The CSS styles for `.bp4 form group` and `.bp4 label` might need adjustment for the inline variant. Reproduce the issue locally and inspect the rendered HTML to determine the root cause. The fix could involve adjusting CSS flexbox properties or the order of elements. Check if there are any existing tests for FormGroup in `packages/core/test/forms/formGroupTests.tsx`.