palantir/blueprint

[Select] Can't select item by keyboard - Enter

Open

#5,191 opened on Mar 22, 2022

View on GitHub
 (3 comments) (0 reactions) (0 assignees)TypeScript (20,263 stars) (2,167 forks)batch import
P2Package: selecthelp wanted

Description

Can't select item by keyboard Enter If replace Button via native button html tag, and set filterable={false}.

Environment

  • Package version(s):
  • Operating System:
  • Browser name and version:

Code Sandbox

Link to a minimal repro: https://codesandbox.io/s/blueprint-sandbox-forked-x7z0uz?file=/src/SelectExample.tsx

Loom: https://www.loom.com/share/2639f8abedff41ac84fe02a7548f0574

Steps to reproduce

  1. child components - native button
  2. filterable={false}
  3. Use Keyboard to select active item

Actual behavior

Can't select item, only if i pressed Enter second time

Expected behavior

Select item by keyboard Enter

Contributor guide

Tech stack
typescriptreacthtmlcss
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic React knowledgeTypeScript familiarity
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Investigate the Select component's keyboard event handling when `filterable={false}` and the item is a native `<button>`. Check the code sandbox for exact behavior. Look in the repository's source code for the Select component, particularly the `onKeyDown` or similar handlers that manage Enter key selection. The issue likely involves a conditional that skips selection on first press due to filterable=false. Examine related comments in the issue for additional clues.