palantir/blueprint

[Select] Can't select item by keyboard - Enter

Open

#5,191 opened on Mar 22, 2022

View on GitHubContributor guide
 (3 comments) (0 reactions) (0 assignees)TypeScript (2,167 forks)batch import
P2Package: selecthelp wanted

Repository metrics

Stars
 (20,263 stars)
PR merge metrics
 (PR metrics pending)

Description

Can't select item by keyboard Enter If replace Button via native button html tag, and set filterable={false}.

Environment

  • Package version(s):
  • Operating System:
  • Browser name and version:

Code Sandbox

Link to a minimal repro: https://codesandbox.io/s/blueprint-sandbox-forked-x7z0uz?file=/src/SelectExample.tsx

Loom: https://www.loom.com/share/2639f8abedff41ac84fe02a7548f0574

Steps to reproduce

  1. child components - native button
  2. filterable={false}
  3. Use Keyboard to select active item

Actual behavior

Can't select item, only if i pressed Enter second time

Expected behavior

Select item by keyboard Enter

Contributor guide

Research direction
Examine the Select component's keyboard event handling for Enter key when filterable is false and the child element is a native button. Focus on the onKeyDown or onKeyUp handlers and how the selection logic is triggered.
Tech stack
typescriptreact
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
ReactGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60