palantir/blueprint

Merging props when using Popover2 renderTarget

Open

#5,079 opened on Dec 21, 2021

View on GitHub
 (2 comments) (0 reactions) (0 assignees)TypeScript (20,263 stars) (2,167 forks)batch import
Domain: APIP2Package: popover2help wanted

Description

Environment

  • Package version(s): @blueprintjs/core": "^3.52.0, @blueprintjs/popover2": "^0.12.9
  • Browser and OS versions: Version 96.0.4664.110 (Official Build) snap (64-bit)

Feature request

When using the renderTarget feature of Popover2 (specifically, I'm using Tooltip2), it is not clear which properties are actually used. For example, it seems that if you use {...tooltipProps} and then {className="my-class"}, the latter will overwrite the former and the bp2-popover2-target class will be lost.

Examples

        <Tooltip2
            content="my tooltip"
            renderTarget={({
                ref: tooltipRef,
                isOpen: _tooltipIsOpen,
                ...tooltipProps
            }) => (
                <Button
                    elementRef={tooltipRef as IRef<HTMLButtonElement>}
                    {...tooltipProps}
                    className="my-class" // !!! this overwrites property from ...tooltipProps !!!
                </Button>
            )}
        />

Contributor guide

Tech stack
typescriptreact
Domain
frontend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
ReactTypeScriptprop merging
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
The issue requests clarity on prop merging when using renderTarget in Popover2/Tooltip2. The user demonstrates that className overrides the bp2 popover2 target class. To resolve, investigate how renderTarget passes props and ensure proper merging, possibly by using a unique key or merging classNames. Check the source code for renderTarget in Popover2.tsx and Tooltip2.tsx. No linked PRs or maintainer comments.
Merging props when using Popover2 renderTarget · palantir/blueprint#5079 | Good First Issue