palantir/blueprint

v3.18.1 Select never looks for itemPredicate exactMatch on paste

Open

#5,078 opened on Dec 21, 2021

View on GitHub
 (1 comment) (0 reactions) (0 assignees)TypeScript (20,263 stars) (2,167 forks)batch import
P2Package: selectType: bughelp wanted

Description

Environment

  • Package version(s): 3.18.1
  • Operating System: macOS Big Sur 11.6
  • Browser name and version: Jest/jsdom?

Code Sandbox

Link to a minimal repro (fork this code sandbox): https://codesandbox.io/s/blueprint-sandbox-forked-mvldg?file=/src/SelectExample.tsx

Steps to reproduce

  1. Open select example.
  2. Paste "First" into the input.
  3. See how the alert is never triggered

Actual behavior

exactMatch is never set on the predicate, even though you paste the exact test or key.

Expected behavior

Pasting into the input should run the ItemPredicate with exactMatch of true to find the item with exact value. image

Possible solution

It doesn't seem like Select is spreading handlePaste into the renderer, so the renderer never handles paste events.

Contributor guide

Tech stack
typescriptreact
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic knowledge of ReactFamiliarity with Blueprint Select component
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
The issue is that Select does not pass the paste handler to its renderer, so itemPredicate's exactMatch is never set to true on paste. Inspect the Select component source (likely in src/components/select/select.tsx) to see how handlePaste is not being spread into the renderer props. Compare with the code sandbox to verify the behavior. The fix involves ensuring paste events are handled and exactMatch is correctly passed to the predicate.