palantir/blueprint

Cannot use Enter key in dialog/textarea spawned from Table

Open

#5,042 opened on Nov 29, 2021

View on GitHub
 (2 comments) (0 reactions) (0 assignees)TypeScript (20,263 stars) (2,167 forks)batch import
P2Package: corePackage: tableType: bughelp wanted

Description

Environment

  • Package version(s): table 3.9.12, core 3.49.1
  • Operating System: windows
  • Browser name and version: firefox and chrome

Code Sandbox

https://codesandbox.io/s/blueprint-sandbox-forked-r06o8?file=/src/index.tsx

image

Actual behavior

Cannot insert new lines by typing Enter in textarea in dialog which is a child of a Table

It behaves as if the table intercepted the Enter key. All other keys seem to work normally. It is possible to insert new lines by pasting (Ctrl-V).

Expected behavior

Can use the Enter key in textarea of dialog which is a child of a Table

Possible solution

Contributor guide

Tech stack
typescriptreact
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic ReactEvent handling in React
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
The issue is that the Table component intercepts the Enter key event, preventing it from reaching a textarea inside a Dialog. Investigate the Table's key event handling code, likely in src/components/table/ or similar. Look for any event.stopPropagation() or event.preventDefault() on Enter key. The fix may involve not propagating the event when the target is a textarea or dialog. Check the existing comments for any hints.