palantir/blueprint

Default overlay leave transition does not fade content nicely

Open

#4,923 opened on Sep 21, 2021

View on GitHub
 (0 comments) (1 reaction) (0 assignees)TypeScript (20,263 stars) (2,167 forks)batch import
P3Package: coreType: enhancementhelp wanted

Description

Environment

  • Package version(s): 3.49.1

Code Sandbox

Link to a minimal repro https://codesandbox.io/s/blueprint-overlay-ktx4f?file=/src/index.tsx

Steps to reproduce

  1. Open overlay with button
  2. click outside overlay to close it
  3. the backdrop fades but the card hangs for a second and then disappears in a very clunky transition

Expected behavior

The default transition should match the fade of the backdrop so that it looks nice. The docs use a custom transition. It would be nice to cleanup the default transition and use that instead.

Possible solution

Contributor guide

Tech stack
typescriptreactcss
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
React basicsCSS transitions
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Examine the Overlay component in the Blueprint source code, likely in packages/core/src/components/overlay. The default transition classes (e.g., pt overlay enter, pt overlay leave) need to be adjusted to match the fade timing of the backdrop. Check the transition definitions in the CSS files. The docs mention a custom transition; consider aligning the default with that.
Default overlay leave transition does not fade content nicely · palantir/blueprint#4923 | Good First Issue