palantir/blueprint

Numeric input - Basic example: page crash on selecting default locale

Open

#4,876 opened on Aug 25, 2021

View on GitHub
 (0 comments) (1 reaction) (0 assignees)TypeScript (20,263 stars) (2,167 forks)batch import
Domain: documentationP2Type: bughelp wanted

Description

https://github.com/palantir/blueprint/blob/2db16b00fcf4f9eeb2defb0cb4f5b43a19c10762/packages/docs-app/src/examples/core-examples/numericInputBasicExample.tsx#L157

Low prio

In the docs section for Numeric input - Basic example, selecting any option in the Locale selector, then going back to default option results in page crash due to incorrect locale information provided.

Current: [{ label: "Default", value: "" }, ...LOCALES]

Expected: [{ label: "Default", value: "en-US" }, ...LOCALES] Suggesting "en-US" as convenience fallback.

cc: @adidahiya

Contributor guide

Tech stack
reacttypescript
Domain
frontenddocumentation
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90
Research direction
The crash occurs in packages/docs app/src/examples/core examples/numericInputBasicExample.tsx at line 157. The fix is to change the default locale value from an empty string to 'en US' in the select options. Verify by running the docs app locally and testing that selecting any locale then back to Default does not crash the page.