palantir/blueprint

[MultistepDialog] Allow side navigation to be disabled (e.g. when submitting)

Open

#4,872 opened on Aug 20, 2021

View on GitHub
 (3 comments) (0 reactions) (0 assignees)TypeScript (20,263 stars) (2,167 forks)batch import
P2Package: coreType: feature requesthelp wanted

Description

Environment

  • Package version(s): @blueprintjs/core@3.48.0

Feature Request

  1. Add a disabled prop to <MultistepDialog> that would allow the side navigation to be disabled (e.g when the dialog is being submitted)

  2. Perhaps if specified true (and ignored as false | undefined), it could also combine & override any individual disabled props for all the other steps' nextButtonProps and backButtonProps? (You can see in my Code Sandbox example, I am passing || submitting through to most of them)

Code Sandbox

https://codesandbox.io/s/blueprint-sandbox-multistepdialog-4di0d

Steps to reproduce

(Using the example in the Code Sandbox)

  1. Advance through each step of the <MultistepDialog> to the end.
  2. See how each step must be "valid" before you can progress.
  3. On the last step, click the "Submit" button to trigger a fake submit state.
  4. ❌ See that you can still navigate around between past steps via the side navigation whilst the form submit is ongoing.

Contributor guide

Tech stack
typescriptreact
Domain
frontend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
ReactBlueprint component usageTypeScript basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Examine the MultistepDialog source code at `@blueprintjs/core` to understand the current side navigation implementation. Look for the component's props interface and how step navigation is handled. Consider adding a `disabled` prop that disables side navigation (e.g., during submission) and possibly overrides individual step button props. Review the code sandbox linked in the issue for reproduction context. Check for existing tests in the repository to ensure new behavior is covered.