palantir/blueprint

[MultistepDialog] Navigation to later steps is allowed via side navigation when `nextButtonProps` disallows it

Open

#4,871 opened on Aug 20, 2021

View on GitHub
 (0 comments) (0 reactions) (0 assignees)TypeScript (20,263 stars) (2,167 forks)batch import
P2Package: coreType: bughelp wanted

Description

Environment

  • Package version(s): @blueprintjs/core@3.48.0

Code Sandbox

https://codesandbox.io/s/blueprint-sandbox-multistepdialog-4di0d

Steps to reproduce

(Using the example in the Code Sandbox)

  1. Advance through each step of the <MultistepDialog> to the end.
  2. See how each step must be "valid" before you can progress.
  3. Before submitting, go back to an earlier step via the "Back" buttons or via the side navigation.
  4. Uncheck the checkbox to make the step invalid.
  5. ✅ See that the "Next" button on the step is now disabled (according to nextButtonProps on that step)
  6. ❌ See that you can still navigate to the next step via the side navigation, as it was previously visited.

Actual behavior

image

Expected behavior

image

If the "Next" button of the current <DialogStep> is disabled through the nextButtonProps, I do not expect to be able to navigate further forwards through the steps via the side navigation; even if I have advanced further previously.

Contributor guide

Tech stack
typescriptreact
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Familiarity with Blueprint's MultistepDialogBasic React understanding
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Investigate the step navigation logic in MultistepDialog, likely in packages/core/src/components/dialog/multistepDialog.tsx. The side navigation clicks probably call a handler like handleStepClick that advances steps without checking if nextButtonProps is disabled. Modify this handler to check the current step's nextButtonProps.disabled before allowing forward navigation. Also ensure that step validity (e.g., checkbox state) is re evaluated when navigating via side panel. Refer to the CodeSandbox for reproduction steps and expected behavior.