palantir/blueprint

[InputGroup] Cannot set fill to false

Open

#4,857 opened on Aug 14, 2021

View on GitHub
 (1 comment) (0 reactions) (0 assignees)TypeScript (20,263 stars) (2,167 forks)batch import
P3Package: coreType: bughelp wanted

Description

Environment

  • Package version(s): 3.47.0
  • Operating System: Windows 10
  • Browser name and version: Google Chrome - v92.0.4515.131 (Official Build) (64-bit)

Code Sandbox

Link to a minimal repro: https://codesandbox.io/s/blueprint-sandbox-forked-68yys?file=/src/CoreExample.tsx

Steps to reproduce

  1. Create an InputGroup with fill=true
  2. Create another InputGroup with fill=false
  3. Both inputs look the same

Actual behavior

The fill prop cannot be set to false

Expected behavior

Setting the fill prop to false should make the component not to take up the full width of its container

Possible solution

TBH I'm not sure what's the solution for this one. I tried moving some styles in .bp3-input-group and .bp3-input, but doing so breaks a lot of components that depend on other inputs that are also using those classes (that's something I hate about CSS classes. To me It's so good we have styled-components now 😅)

Contributor guide

Tech stack
reacttypescript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
ReactCSSBlueprint components
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
55
Research direction
Investigate the CSS for .bp3 input group and .bp3 input to understand why fill=false does not apply. Check the component's className logic. Possibly the component always adds the fill class or the CSS priority issue. Look at the InputGroup source code and related CSS files. Consider a minimal fix that overrides width when fill=false.