palantir/blueprint

LabelElement Icon doesn't highlight on hover in dark mode

Open

#4,809 opened on Jul 19, 2021

View on GitHub
 (0 comments) (0 reactions) (0 assignees)TypeScript (20,263 stars) (2,167 forks)batch import
P2Package: coreType: bughelp wanted

Description

Environment

  • Package version(s): 3.46.0
  • Operating System: MacOS Catalina
  • Browser name and version: Chrome

Code Sandbox

Link to a minimal repro: https://blueprintjs.com/docs/#core/components/menu

Steps to reproduce

View the menu item behavior shown in the link above. This is just a comment on the current features of the menu item component.

Actual behavior

The right icon (labelElement) does not highlight on hover in dark mode unlike the left icon.

Expected behavior

The right icon should highlight on hover in dark mode like the left icon, at least for cases where there is only the right icon being rendered.

Possible solution

Add a highlight styling on hover for the labelElement.

Contributor guide

Tech stack
cssreacttypescript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic CSSfamiliarity with Blueprint theming
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90
Research direction
The fix involves adding a CSS rule for the labelElement hover state in dark mode. Look at the Menu component's styles, likely in the `packages/core/src/components/menu/` directory. The issue suggests adding a hover style similar to the left icon's hover effect. Check the existing hover styles for menu items and replicate for `.bp3 menu item .bp3 file label` (or similar selector) in dark mode. No linked PR or assignee, so the issue is available for contribution.