palantir/blueprint

Popover v2 always take focus even if autoFocus is disabled

Open

#4,792 opened on Jul 2, 2021

View on GitHub
 (10 comments) (0 reactions) (0 assignees)TypeScript (20,263 stars) (2,167 forks)batch import
P2Package: popover2Type: bughelp wanted

Description

Environment

  • Package version(s): "@blueprintjs/core": "^3.46.0", "@blueprintjs/popover2": "^0.11.0",
  • Operating System: Mac OS, Big Sur 11.4
  • Browser name and version: Chrome Version 91.0.4472.114 (Build officiel) (x86_64)

Code Sandbox

https://codesandbox.io/s/restless-dust-b4ggf?file=/src/App.tsx

Context

I'm trying to create a component that behave close to Suggest but i can't rely on InputGroup. I try to build my own version but i'm blocked with popover v2 because focus is always take by the popover even if autoFocus props is marked as false.

Actual behavior

Input lose focus when popover open or close event if autoFocus is disabled.

Expected behavior

When autoFocus is disabled popover is not focus when open or close.

Contributor guide

Tech stack
typescriptreact
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
ReactTypeScriptBlueprintJS
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Focus on the Popover2 component source in the @blueprintjs/popover2 package. Investigate the autoFocus prop handling in the open/close logic, specifically where focus is programmatically set. Check the Overlay component as it might manage focus. The issue reports that focus is always taken even when autoFocus is disabled; likely a missing conditional check.