palantir/blueprint

DateInput popover opens again after editing hours or minutes

Open

#4,776 opened on Jun 23, 2021

View on GitHub
 (2 comments) (0 reactions) (0 assignees)TypeScript (20,263 stars) (2,167 forks)batch import
P2Package: datetimeType: bughelp wanted

Description

Environment

  • Environment
  • Package version(s):
    • "@blueprintjs/core": "3.31.0"
    • "@blueprintjs/datetime": "^3.23.4"
  • Operating System: Mac OS 10.15.7
  • Browser name and version: Chrome 91.0.4472.114

Code Sandbox

Link to a minimal repro: https://codesandbox.io/embed/popover-popping-up-again-n5r7v?fontsize=14&hidenavigation=1&theme=dark

Steps to reproduce

  1. Have time showing in the DateInput
  2. Select any date
  3. Edit either the hour or minute inputs inside the popover (not directly in the date input)
  4. Click outside of the popover to close

Actual behavior

The popover reopens itself. Note this does not happen with seconds.

Expected behavior

The popover should close.

Contributor guide

Tech stack
typescriptreact
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic knowledge of Reactunderstanding of popover behavior
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Investigate the DateInput component in the Blueprint codebase, focusing on the popover close logic. The bug occurs when editing hours or minutes (but not seconds) inside the popover. Check the onChange and onClose handlers in the DateInput component, specifically how the popover state is managed. Look at the linked CodeSandbox for reproduction. The fix likely involves preventing the popover from reopening after a valid edit or modifying the blur event handling.