palantir/blueprint

Text overflow wrapping for time picker

Open

#4,702 opened on May 7, 2021

View on GitHub
 (0 comments) (0 reactions) (0 assignees)TypeScript (2,167 forks)batch import
P2Package: datetimeType: feature requesthelp wanted

Repository metrics

Stars
 (20,263 stars)
PR merge metrics
 (Avg merge 43d 10h) (27 merged PRs in 30d)

Description

I think it would be helpful to support time wrapping for time picker when using the arrow keys. It seems unintuitive for 4:00 -> arrow down -> 4:59 instead of wrapping to 3:59.

Currently workarounds are not possible since origin of time change (hours, minutes seconds) and direction of change are not accessible from the onChange callback.

Thank you for your consideration!

Contributor guide

Research direction
Modify the time picker component to wrap time values when using arrow keys. Specifically, adjust the handler for increment/decrement to wrap around boundaries (e.g., 4:00 down arrow > 3:59).
Tech stack
typescriptreact
Domain
frontend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
ReactTypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75