palantir/blueprint

Text overflow wrapping for time picker

Open

#4,702 opened on May 7, 2021

View on GitHub
 (0 comments) (0 reactions) (0 assignees)TypeScript (20,263 stars) (2,167 forks)batch import
P2Package: datetimeType: feature requesthelp wanted

Description

I think it would be helpful to support time wrapping for time picker when using the arrow keys. It seems unintuitive for 4:00 -> arrow down -> 4:59 instead of wrapping to 3:59.

Currently workarounds are not possible since origin of time change (hours, minutes seconds) and direction of change are not accessible from the onChange callback.

Thank you for your consideration!

Contributor guide

Tech stack
typescriptreact
Domain
frontend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
Look into the TimePicker component in the Blueprint repository (likely in packages/core/src/components/time picker/). Investigate how arrow key handling currently works (onArrowKeyDown or similar) and implement wrapping logic to allow minute/hour cycling. Update the onChange callback to expose the origin and direction of time change if needed.
Text overflow wrapping for time picker · palantir/blueprint#4702 | Good First Issue