palantir/blueprint

Some mechanism for letting EditableText shrink to its content size when not editing

Open

#4,543 opened on Feb 25, 2021

View on GitHub
 (0 comments) (0 reactions) (0 assignees)TypeScript (20,263 stars) (2,167 forks)batch import
P2Package: coreType: enhancementhelp wanted

Description

So this mostly already happens, but the min-width on the inner span is set to 80px. Have a UI like this:

Without doing some css hacking to unset the min-width, it ends up looking like this:

css hacking I'm doing is:

.display-name-value {
    max-width: 250px;

    > :last-child {
        // Need our EditableTexts to contract to their content size
        /* stylelint-disable declaration-no-important */
        min-width: unset !important;
        /* stylelint-enable declaration-no-important */
    }
}

but that's obviously really flaky, so was hoping for a more formal way to remove/lower the min-width (unset isn't necessarily correct because you get into a weird spot if you don't have a placeholder, but want the ability to make it lower than 80px at least)

Contributor guide

Tech stack
typescriptreactcss
Domain
frontend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
ReactCSSBlueprint component basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
Examine the EditableText component in the Blueprint repo (likely in packages/core/src/components/editable text). The issue requests a formal mechanism to control or remove the hardcoded min width on the inner span (currently 80px). Consider adding a prop like `shrinkToContent` or `minWidth` that defaults to 80px but can be set to smaller or 'unset'. Look at existing styling logic for the span and how props are passed to the component's state. No linked PRs or comments provide guidance, so the solution should be a non breaking addition.
Some mechanism for letting EditableText shrink to its content size when not editing · palantir/blueprint#4543 | Good First Issue