palantir/blueprint

Add selectAllOnFocus prop to DateInput component

Open

#4,530 opened on Feb 17, 2021

View on GitHub
 (0 comments) (0 reactions) (0 assignees)TypeScript (20,263 stars) (2,167 forks)batch import
P2Package: datetimeType: feature requesthelp wanted

Description

Environment

  • Package version(s): latest
  • Browser and OS versions: all

Feature request

The DateInput component has the missing ability to select all text inside text input. I found this behavior very usable. As i can see DateRangeInput has selectAllOnFocus prop, which i think must be presented and in DateInput too.

BTW. I don’t know but maybe it would be better to add prop which controls this behavior directly to InputGroup component

Contributor guide

Tech stack
typescriptreact
Domain
frontend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
ReactTypeScriptbasic understanding of component props
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80
Research direction
Examine the existing DateRangeInput component to understand how the selectAllOnFocus prop is implemented. Then, add a similar prop to DateInput. Additionally, consider whether it would be better to add this behavior to the InputGroup component as suggested in the issue. Key files to review: src/components/date input/dateInput.tsx and src/components/date range input/dateRangeInput.tsx.