palantir/blueprint

DateRangeInput placeholder not working

Open

#4,487 opened on Jan 20, 2021

View on GitHub
 (1 comment) (1 reaction) (0 assignees)TypeScript (20,263 stars) (2,167 forks)batch import
P2Package: datetimeType: enhancementhelp wanted

Description

Environment

  • Package version(s): @blueprintjs/datetime 3.18.5
  • Operating System: macOS Big Sur Version 11.1
  • Browser name and version: Chrome Version 87.0.4280.141 (Official Build) (x86_64)

Code Sandbox

Link to a minimal repro: https://codesandbox.io/s/blueprint-sandbox-forked-rk722?file=/src/DatetimeExample.tsx

Steps to reproduce

Specify placeholder on DateRangeInput e.g. "Please enter date"

Actual behavior

Placeholders say "Start date" and "End date"

Expected behavior

Placeholders should be the specified string e.g. "Please enter date"

Possible solution

Since there are two fields, the placeholder should be [string, string] for the start date and end date respectively

Contributor guide

Tech stack
reacttypescriptcss
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
ReactTypeScriptBlueprint.js
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Investigate the DateRangeInput component in packages/datetime/src/dateRangeInput.tsx. The placeholder prop currently accepts a single string but should accept a tuple [string, string] for start and end dates. Check the component's prop typing and rendering logic to implement the fix. The issue also suggests updating documentation if applicable.