palantir/blueprint

DateRangeInput placeholder not working

Open

#4,487 opened on Jan 20, 2021

View on GitHub
 (1 comment) (1 reaction) (0 assignees)TypeScript (2,167 forks)batch import
P2Package: datetimeType: enhancementhelp wanted

Repository metrics

Stars
 (20,263 stars)
PR merge metrics
 (Avg merge 43d 10h) (27 merged PRs in 30d)

Description

Environment

  • Package version(s): @blueprintjs/datetime 3.18.5
  • Operating System: macOS Big Sur Version 11.1
  • Browser name and version: Chrome Version 87.0.4280.141 (Official Build) (x86_64)

Code Sandbox

Link to a minimal repro: https://codesandbox.io/s/blueprint-sandbox-forked-rk722?file=/src/DatetimeExample.tsx

Steps to reproduce

Specify placeholder on DateRangeInput e.g. "Please enter date"

Actual behavior

Placeholders say "Start date" and "End date"

Expected behavior

Placeholders should be the specified string e.g. "Please enter date"

Possible solution

Since there are two fields, the placeholder should be [string, string] for the start date and end date respectively

Contributor guide

Research direction
Inspect the DateRangeInput component implementation to see how placeholder prop is passed to the start and end input fields, and fix it to support a string or tuple.
Tech stack
typescriptreact
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
ReactTypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75