palantir/blueprint

EditableText does not measure contents correctly when alwaysRenderInput=true

Open

#4,423 opened on Nov 17, 2020

View on GitHub
 (1 comment) (3 reactions) (0 assignees)TypeScript (20,263 stars) (2,167 forks)batch import
P2Package: coreType: bughelp wanted

Description

Environment

  • Package version(s): core 3.36.0
  • Operating System: macOS
  • Browser name and version: Chrome 86

Code Sandbox

https://codesandbox.io/s/editabletext-alwaysrenderinput-bug-5x99u?file=/src/index.tsx (forked from https://github.com/palantir/blueprint/issues/3870#issue-530056037)

Steps to reproduce

  1. open the sandbox

Actual behavior

First EditableText is clipped, second one is full width of contents

Expected behavior

Both should display full width of contents

Possible solution

...

Contributor guide

Tech stack
typescriptreact
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic knowledge of ReactFamiliarity with Blueprint's EditableText component
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Investigate the EditableText component in Blueprint's source, specifically the handling of the alwaysRenderInput prop. Look at how content width is measured when alwaysRenderInput is true, comparing the behavior when it's false. Focus on the CSS and the component's logic for setting input width. The issue likely involves a missing or incorrect measurement of the input's content width, possibly related to the component's state or refs. Check the forked sandbox for a live reproduction and test a fix by ensuring the input width is calculated correctly for both modes.