palantir/blueprint

TagInput should have a string-only variant with simpler prop types

Open

#4,390 opened on Oct 27, 2020

View on GitHub
 (0 comments) (0 reactions) (0 assignees)TypeScript (2,167 forks)batch import
Package: coreType: enhancementhelp wanted

Repository metrics

Stars
 (20,263 stars)
PR merge metrics
 (Avg merge 43d 10h) (27 merged PRs in 30d)

Description

Working with onRemove: (value: React.ReactNode, index: number) is inconvenient under TypeScript's strict compiler options. Even when the values prop is string[], you are either forced to type cast the removed value to string or use the index parameter to index into your values array. We should make the simple case easier to work with, either with a new component API or changing the existing component to be parameterized by its data type <T>.

Contributor guide

Research direction
Study the current TagInput component API and its usage of React.ReactNode for the onRemove callback. Design a generic type parameter <T> to support string only values or a separate variant. Implement the change while ensuring backward compatibility.
Tech stack
typescriptreact
Domain
frontend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
ReactTypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70