palantir/blueprint

[TimezonePicker] 'inputProps' does not override search behavior.

Open

#4,353 opened on Sep 30, 2020

View on GitHub
 (2 comments) (0 reactions) (0 assignees)TypeScript (20,263 stars) (2,167 forks)batch import
P3Type: bughelp wanted

Description

Steps to reproduce

        <TimezonePicker
          ...
          inputProps={{
            value: this.searchQuery,
            onChange: this.handlerWhichShouldBeCalledButItIsnt
          }}
        >

Actual behavior

Callback for search input change is not called.

Expected behavior

According to docs callback for search input change should override Select's behavior and should be called.

Possible solution

The onQueryChange prop which you pass to Select in timezonePicker.tsx is just:

private handleQueryChange = (query: string) => this.setState({ query });

No mentions about inputProps.onChange.

And as I understand in Select onQueryChange has some priority over inputProps.onChange. Thus my callback which I pass to TimezonePicker is not called.

But it's just an assumption.

Please let me know if I do something wrong...

Contributor guide

Tech stack
typescriptreact
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
ReactTypeScriptfamiliarity with Blueprint
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Examine the TimezonePicker component in timezonePicker.tsx and how it passes inputProps to the Select component. The issue indicates that onQueryChange in Select may override inputProps.onChange. Look at the Select component's handling of inputProps to ensure the onChange callback from inputProps is called. Review any existing PRs or comments for guidance.
[TimezonePicker] 'inputProps' does not override search behavior. · palantir/blueprint#4353 | Good First Issue