palantir/blueprint

Omnibar selects first entry on empty query

Open

#4,330 opened on Sep 11, 2020

View on GitHub
 (0 comments) (1 reaction) (0 assignees)TypeScript (20,263 stars) (2,167 forks)batch import
P2Package: selectType: bughelp wanted

Description

Environment

  • Package version(s): 3.31.0
  • Operating System: macOS 10.15.6
  • Browser name and version: Chrome 85.0.4183.83

Steps to reproduce

  1. Visit https://blueprintjs.com/docs/#select/omnibar
  2. Open the omnibar (there are no movies displayed)
  3. Press enter
  4. A toast "You selected The Shawshank Redemption." will appear

Actual behavior

An empty search string still selects the first entry in the list.

Expected behavior

Nothing.

Contributor guide

Tech stack
typescriptreactcss
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic React knowledgeFamiliarity with Blueprint components
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85
Research direction
Examine the Omnibar component in the Blueprint repository, likely in `packages/select/src/components/omnibar/`. Focus on the logic that handles key presses or selection when the query is empty. Look for a missing conditional check that prevents selecting the first item when the query is an empty string. Review the component's state and the `handleKeyDown` or similar method to identify where the fix should be applied.