palantir/blueprint

Entire Frozen Column Scroll Up/Down When Press Arrow Up/Down Keys

Open

#4,237 opened on Jul 22, 2020

View on GitHub
 (0 comments) (0 reactions) (0 assignees)TypeScript (20,263 stars) (2,167 forks)batch import
Browser: ChromePackage: tableType: bughelp wanted

Description

Please check the Codesandbox and use the steps to reproduce to observe the issue, thank you.

Environment

  • Package version(s): blueprintjs core@3.17.1, table@3.6.0, react@16.8.5, react-router-dom@5.1.0
  • Operating System: MacOS@10.15.5
  • Browser name and version: Google Chrome@83.0.4103.116 (Official Build) (64-bit)

The latest version of blueprintjs packages still have this issue.

Code Sandbox

https://codesandbox.io/s/gracious-jepsen-oivtr

Steps to reproduce

  1. Open the sandbox.
  2. When you see the table click any cell of "Dollars" column.
  3. When you see the popup dialog press Esc in keyboard, the popup dialog should be closed.
  4. Press Down/Up arrow key in keyboard.

Actual behavior

Observe the frozen column(Dollars column) will be entirely scroll down/up.

Expected behavior

Click "Close" button or click outside to close the popup dialog does not trigger this issue.

Contributor guide

Tech stack
typescriptreact
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic knowledge of ReactUnderstanding of Blueprint table component
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45
Research direction
Investigate the event handling when a popup dialog is closed via the Escape key and then arrow keys are pressed. The issue likely involves the table component's keyboard event listeners not properly releasing focus or handling the frozen column scroll. Look at the table component source in packages/table/src/ for key event handlers and the frozen column implementation. Check if there is a related PR or discussions in the Blueprint repository.