palantir/blueprint

ItemPredicate make onActiveItemChange fired twice and active item isn't the good one

Open

#4,192 opened on Jun 25, 2020

View on GitHub
 (4 comments) (5 reactions) (0 assignees)TypeScript (20,263 stars) (2,167 forks)batch import
P2Package: selectType: bughelp wanted

Description

Environment

  • Package version(s): 3.28.1
  • Operating System: Mac OS - latest
  • Browser name and version: chrome Version 83.0.4103.106 (Build officiel) (64 bits)

Steps to reproduce

  1. Define a Select component with a custom item list render and item render
  2. Add itemPredicate function
  3. select an item
  4. Open the Select back ( active item isn't item selected )

Actual behavior

I don't know why but onActiveItemChange is fired twice when a itemPredicate is defined. First you get the selected item and just after onActiveItemChange is fired with the first item in the list with no reason.

Expected behavior

ActiveItem is the selected item when you open the list after a select.

Contributor guide

Tech stack
typescriptreact
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
ReactBlueprint Select component
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Investigate the onActiveItemChange callback in the Select component, specifically how itemPredicate affects active item state. Look at the source code in packages/core/src/components/select/select.tsx and related handler functions. Check if active item reset occurs when predicate filters the list, causing the first item to become active incorrectly.