palantir/blueprint

[select] MultiSelect and Suggest openOnKeyDown props behave differently

Open

#4,152 opened on May 26, 2020

View on GitHub
 (0 comments) (1 reaction) (0 assignees)TypeScript (20,263 stars) (2,167 forks)batch import
Domain: APIP3Type: bughelp wanted

Description

we should make MultiSelect also open immediately on focus when using a TAB key interaction. we can do this by adding inputProps.onFocus support to TagInput.

Contributor guide

Tech stack
typescriptreact
Domain
frontendaccessibility
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
ReactTypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
The fix involves adding an onFocus handler to TagInput's inputProps. Look at the TagInput component (src/components/tag input/tagInput.tsx). Then ensure MultiSelect uses this new prop to open on TAB focus. Check the existing openOnKeyDown prop in Suggest for reference.