palantir/blueprint

FR: components should be able to operate in child window documents

Open

#3,972 opened on Feb 19, 2020

View on GitHub
 (0 comments) (0 reactions) (0 assignees)TypeScript (20,263 stars) (2,167 forks)batch import
Package: coreType: feature requesthelp wanted

Description

currently, some components like (e.g. NumericInput) reference window.document implicitly, which can may not be the document of the window where the component is being rendered in the case of React portal techniques like this one. we should look into supporting this use case.

possible solution: define a blueprint React context which includes an optional field which sets this.document on all components

Contributor guide

Tech stack
typescriptreact
Domain
frontend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Familiarity with React ContextUnderstanding of React portal behaviorBasic knowledge of Blueprint component architecture
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
The issue proposes a React context to allow components to reference a custom document object for child window support. The main file to examine is `packages/core/src/components/forms/numericInput.tsx` where `window.document` is used implicitly. The goal is to introduce a context with an optional `document` field and update components to use it. No linked PRs or existing work; the issue remains open with no comments. A newcomer should first understand how Blueprint uses React context (e.g., for theming) and then prototype a solution that overrides the document reference in components like NumericInput.