palantir/blueprint

FR: components should be able to operate in child window documents

Open

#3,972 opened on Feb 19, 2020

View on GitHub
 (0 comments) (0 reactions) (0 assignees)TypeScript (2,167 forks)batch import
Package: coreType: feature requesthelp wanted

Repository metrics

Stars
 (20,263 stars)
PR merge metrics
 (Avg merge 43d 10h) (27 merged PRs in 30d)

Description

currently, some components like (e.g. NumericInput) reference window.document implicitly, which can may not be the document of the window where the component is being rendered in the case of React portal techniques like this one. we should look into supporting this use case.

possible solution: define a blueprint React context which includes an optional field which sets this.document on all components

Contributor guide

Research direction
Investigate the components that reference window.document implicitly (e.g., NumericInput) and create a React context that provides a custom document object for use in child windows or portals.
Tech stack
reacttypescript
Domain
frontend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
ReactTypeScriptReact context
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60