palantir/blueprint

Tab navigation not working with Suggest

Open

#3,945 opened on Jan 28, 2020

View on GitHub
 (2 comments) (0 reactions) (0 assignees)TypeScript (2,167 forks)batch import
Browser: IE (deprecated)Package: selectType: bughelp wanted

Repository metrics

Stars
 (20,263 stars)
PR merge metrics
 (Avg merge 43d 10h) (27 merged PRs in 30d)

Description

Environment

  • Package version(s): 3.9.0
  • Browser and OS versions: IE11 (11.950.17134.0) / Edge (42.17134.1.0 & EdgeHTML 17.17134)

Steps to reproduce

  1. Go to https://blueprintjs.com/docs/#select/suggest
  2. Use tab key to focus on Suggest input
  3. Press tab again, and the focus will be on the blueprint logo instead of the nearest element (on Chrome, the focus will be on the "Close on select" toggle

Actual behavior

Once focused on the Suggest input, when pressing tab, the focus will be on the blueprint logo.

(In my case, something similar happens where the top element will be focused on rather than the next input.)

Expected behavior

Upon pressing tab, the focus will be on the nearest element (the "Close on select" toggle in this particular example).

(In my case, the next focus would be on the nearest input).

Contributor guide

Research direction
Investigate the Suggest component's focus management and tab order. Look at the component's keyboard event handlers and how it sets focus on open/close. Check if the popover or overlay is capturing focus incorrectly. Compare behavior on different browsers.
Tech stack
typescriptreact
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
ReactTypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75