palantir/blueprint

Input for filtering a Select component can not be used if the Select is inside a Drawer

Open

#3,854 opened on Nov 17, 2019

View on GitHub
 (6 comments) (2 reactions) (0 assignees)TypeScript (20,263 stars) (2,167 forks)batch import
P2Type: bughelp wanted

Description

Environment

  • Package version(s): @blueprintjs/core: 3.17.2 / @blueprintjs/select: 3.11.2
  • Browser and OS versions: Google Chrome 78.0.3904.97 / Windows 10 Pro

Code Sandbox with the issue https://codesandbox.io/s/blueprint-sandbox-2o2rt

Steps to reproduce

  1. Install @blueprintjs/core: 3.17.2 and create a basic select inside a drawer
  2. Run the application / open the sandbox
  3. A drawer will open an inside of it there will be a Select component with the filter option enabled
  4. Click on the text input to filter some values

Actual behavior

The input text field can not be clicked (or focused) and no characters appear when writing.

Expected behavior

The input text field can be clicked and characters can be typed.

Possible solution

I've done some testing, this is a bug for 3.17.2, after updating to 3.20.0 the issue was solved.

Note: after upgrading to 3.20.0, a clean installation is required (deleting the node_modules folder and deleting the package-lock.json file) otherwise the issue will still be present, this may be a caching issue on npm (?)

Question: 3.17.2 seems to be the latest published version but 3.20.0 is also available and was published earlier, is this intentional? when will 3.20.0 be launched as the latest stable release?

Contributor guide

Tech stack
typescriptreactcss
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
React basicsBlueprint componentsnpm troubleshooting
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Look at the git log between versions 3.17.2 and 3.20.0 in the Blueprint repository, focusing on changes to Select and Drawer components. Identify the commit that fixed the input focus issue, and then verify if the fix is present on the current master branch. If so, close this issue as resolved.