palantir/blueprint

Spread data-* attributes onto elements

Open

#3,763 opened on Oct 1, 2019

View on GitHub
聽(11 comments)聽(0 reactions)聽(0 assignees)TypeScript聽(20,263 stars)聽(2,167 forks)batch import
P2Package: coreType: feature requesthelp wanted

Description

Feature request

Currently not all blueprint components propagate their data attributes to the rendered element and it would be great if they would, but for now we'd like to request data-* attributes on the Tab component.

We will can make more feature requests on other elements as we discover which ones are important. 馃槃

Contributor guide

Tech stack
typescriptreact
Domain
frontend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Familiarity with React component patternsUnderstanding of HTML data * attributes
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
Locate the Tab component source file in the Blueprint repository (likely under packages/core/src/components/tab/). Review how other components like Button handle data * attribute propagation (e.g., using ...rest or destructuring props). Plan to spread all data * attributes onto the root DOM element of Tab. Check existing tests for Tab to ensure new functionality is covered. No linked PRs or maintainer comments yet, so scope is clear.
Spread data-* attributes onto elements 路 palantir/blueprint#3763 | Good First Issue