palantir/blueprint

Loading state for tree nodes while children are loading asynchronously

Open

#3,729 opened on Sep 9, 2019

View on GitHub
 (6 comments) (0 reactions) (0 assignees)TypeScript (2,167 forks)batch import
Package: coreType: feature requesthelp wanted

Repository metrics

Stars
 (20,263 stars)
PR merge metrics
 (Avg merge 43d 10h) (27 merged PRs in 30d)

Description

Would it work if one was to set the hasCaret prop to whether or not children are available, display a spinner upon onExpand while fetching content from elsewhere, and then replace the spinner with the actual content upon completion?

If so, what would be an elegant way to display a spinner? At first glance, it seems like the only valid type of children are again tree nodes. Those could at least have a label "loading" and be disabled for the time being, however I would much rather prefer a spinner. Could the children prop be used for this?

Thanks for any hints.

Contributor guide

Research direction
Look at the Tree component implementation to understand how nodes are rendered and where to insert a loading indicator. Consider adding a new prop like `showLoadingSpinner` or customizing the node content.
Tech stack
typescriptreact
Domain
frontend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
ReactTypeScriptBlueprint
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80