palantir/blueprint

Unable to select a single day when the intended day equals the start or the end of a previously selected date range

Open

#3,720 opened on Sep 2, 2019

View on GitHub
 (1 comment) (0 reactions) (0 assignees)TypeScript (20,263 stars) (2,167 forks)batch import
P3Package: datetimeType: enhancementhelp wanted

Description

Environment

  • Package version(s): 3.11.0
  • Browser and OS versions: Google Chrome 76 on macOS 10.14.5

Sandbox: https://codesandbox.io/s/blueprint-sandbox-wsj6f

Steps to reproduce

  1. Select a date range, e.g. from the 3rd of August to the 15th of August.
  2. Now you want to select the 3rd of August as a single-day range.
  3. When clicking on this day, you are unable to select it since it is already the start of the previously selected date range.
  4. The same applies if you want to use the last day of the previously selected date range, the 15th of August.

Actual behavior

When clicking the days in 3. and 4. the buttons are deselected.

Expected behavior

When clicking the days in 3. and 4. the buttons keep selected and can be used for a new single-day range.

Contributor guide

Tech stack
typescriptreact
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Familiarity with ReactUnderstanding of date range picker UIBasic TypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Examine the DateRangePicker component in the Blueprint repository, particularly the selection logic that handles clicks on days that are boundaries of an existing range. The sandbox (https://codesandbox.io/s/blueprint sandbox wsj6f) demonstrates the bug. Look for code that updates the selected range on day click events, likely in packages/datetime/src/dateRangePicker. Check if there are existing tests and consider adding a condition to allow selecting a single day even if it matches a boundary of the previous range. The issue has one comment, which may contain additional context.