palantir/blueprint

[Datetime] clicking end input of DateRangeInput opens to start month when showing contiguous months

Open

#3,718 opened on Aug 28, 2019

View on GitHub
 (3 comments) (0 reactions) (0 assignees)TypeScript (20,263 stars) (2,167 forks)batch import
P3Package: datetimeType: bughelp wanted

Description

Environment

  • Package version(s): @blueprintjs/datetime: 3.9.2
  • Browser and OS versions:

Link to a minimal repro: https://blueprintjs.com/docs/#datetime/daterangeinput

Steps to reproduce

  1. Set Range for 3 month (exp: 1 september - 1 december)
  2. Click to End Date
  3. Calendar opens on Start Date

Actual behavior

aTWNzmzdiH

Expected behavior

calendar opens on End Date

Contributor guide

Tech stack
typescriptreact
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
ReactTypeScriptBlueprint datetime components
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
Investigate the DateRangeInput component source code, specifically the logic that determines which month the calendar opens to when clicking the end input. The bug is that clicking the end input opens to the start month instead of the end month. Look at how focus and calendar initial month are set in the component's state. The fix should ensure that clicking on the end input sets the calendar's initial month to the end date's month. Relevant files are likely in the @blueprintjs/datetime package, such as src/dateRangeInput.tsx or related hooks.