palantir/blueprint

[table] scroll behavior tests failing in local development

Open

#3,660 opened on Jul 13, 2019

View on GitHub
 (2 comments) (0 reactions) (0 assignees)TypeScript (20,263 stars) (2,167 forks)batch import
Domain: testingP2Package: tablehelp wanted

Description

Environment

  • Package version(s): N/A
  • Browser and OS versions: HeadlessChrome 75.0.3770 | macOS 10.14.5 (18F203)

Steps to reproduce

  1. Fork repo
  2. Clone to local
  3. yarn install
  4. yarn verify

Actual behavior

Failing on the karma tests on default develop branch

FAILED TESTS:
  scrollUtils
    measureScrollBarThickness
      ✖ measures correctly when only vertical scrollbar is showing
        HeadlessChrome 75.0.3770 (Mac OS X 10.14.5)
      AssertionError: measures vertical scrollbar correctly: expected 0 to be above 0
          at Context.<anonymous> (test/index.js:156445:74)

      ✖ measures correctly when only horizontal scrollbar is showing
        HeadlessChrome 75.0.3770 (Mac OS X 10.14.5)
      AssertionError: measures horizontal scrollbar correctly: expected 0 to be above 0
          at Context.<anonymous> (test/index.js:156451:78)

      ✖ measures correctly when both scrollbars are showing
        HeadlessChrome 75.0.3770 (Mac OS X 10.14.5)
      AssertionError: measures vertical scrollbar correctly: expected 0 to be above 0
          at Context.<anonymous> (test/index.js:156455:74)

  TableQuadrantStack
    Scroll syncing
      ✖ syncs quadrant scroll offsets when scrolling the main quadrant
        HeadlessChrome 75.0.3770 (Mac OS X 10.14.5)
      AssertionError: expected 1 to equal 2
          at assertScrollPositionEquals (test/index.js:158620:50)
          at Context.<anonymous> (test/index.js:158577:13)

      ✖ syncs quadrant scroll offsets when mouse-wheeling in the main quadrant
        HeadlessChrome 75.0.3770 (Mac OS X 10.14.5)
      AssertionError: expected 1 to equal 2
          at assertScrollPositionEquals (test/index.js:158620:50)
          at Context.<anonymous> (test/index.js:158586:13)

      ✖ syncs quadrant scroll offsets when mouse-wheeling in the top quadrant
        HeadlessChrome 75.0.3770 (Mac OS X 10.14.5)
      AssertionError: expected 1 to equal 2
          at assertScrollPositionEquals (test/index.js:158620:50)
          at Context.<anonymous> (test/index.js:158596:13)

      ✖ syncs quadrant scroll offsets when mouse-wheeling in the left quadrant
        HeadlessChrome 75.0.3770 (Mac OS X 10.14.5)
      AssertionError: expected 1 to equal 2
          at assertScrollPositionEquals (test/index.js:158620:50)
          at Context.<anonymous> (test/index.js:158606:13)

      ✖ syncs quadrant scroll offsets when mouse-wheeling in the top-left quadrant
        HeadlessChrome 75.0.3770 (Mac OS X 10.14.5)
      AssertionError: expected 1 to equal 2
          at assertScrollPositionEquals (test/index.js:158620:50)
          at Context.<anonymous> (test/index.js:158615:13)

Expected behavior

Everything to run swimmingly

Possible solution

I'm unsure if there is a specific branch that I should be building from locally. Following the docs I can't see a specific branch mentioned.

I'm following the specific node & yarn versions, so I'm not sure why that would be an issue.

node: v8.16.0 | yarn: 1.16.0

Contributor guide

Tech stack
typescriptreacthtmlcss
Domain
frontendtesting
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Node.jsYarnUnderstanding of scroll behavior
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
20
Research direction
The issue describes failing Karma tests for scrollUtils and TableQuadrantStack scroll syncing. The errors suggest environment specific behavior (HeadlessChrome version). Steps to reproduce are provided. Since the issue is from 2019, first verify if it is still reproducible with the latest dependencies. If not, the issue may need to be closed. If reproducible, investigate the test assertions and consider whether the scrollbar measurement logic needs adjustment for different browser environments.