palantir/blueprint

Popover's boundary prop does not accept Element objects

Open

#3,570 opened on May 27, 2019

View on GitHub
 (1 comment) (1 reaction) (0 assignees)TypeScript (2,167 forks)batch import
P3Package: coreType: bughelp wanted

Repository metrics

Stars
 (20,263 stars)
PR merge metrics
 (Avg merge 43d 10h) (27 merged PRs in 30d)

Description

Package: @blueprintjs/core@3.15.1

Issue: The boundary field of IPopoverSharedProps (defined here) does not accept values of type Element.

Description: This field (boundary) is only used as the boundariesElement field in flip and preventOverflow objects in Popper modifiers, as seen here. Both of these fields in Popper (defined here and here) accept objects of type Boundary | Element, but the boundary field defined in Blueprint only accepts Boundary.

Possible Solution: Change the type here from PopperBoundary to PopperBoundary | Element.

Contributor guide

Research direction
Find the type definition in packages/core/src/components/popover/popoverSharedProps.ts and change the boundary type from PopperBoundary to PopperBoundary | Element.
Tech stack
typescriptreact
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
TypeScriptGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75