palantir/blueprint

Popover's boundary prop does not accept Element objects

Open

#3,570 opened on May 27, 2019

View on GitHub
 (1 comment) (1 reaction) (0 assignees)TypeScript (20,263 stars) (2,167 forks)batch import
P3Package: coreType: bughelp wanted

Description

Package: @blueprintjs/core@3.15.1

Issue: The boundary field of IPopoverSharedProps (defined here) does not accept values of type Element.

Description: This field (boundary) is only used as the boundariesElement field in flip and preventOverflow objects in Popper modifiers, as seen here. Both of these fields in Popper (defined here and here) accept objects of type Boundary | Element, but the boundary field defined in Blueprint only accepts Boundary.

Possible Solution: Change the type here from PopperBoundary to PopperBoundary | Element.

Contributor guide

Tech stack
typescriptreact
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
TypeScriptReact
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85
Research direction
Change the type definition in `packages/core/src/components/popover/popoverSharedProps.ts` line 42 from `PopperBoundary` to `PopperBoundary | Element`. Ensure consistency with Popper.js types referenced in the issue. Test that the component accepts Element objects without breaking existing usage.