palantir/blueprint

Wrong maxTime displayed in DateRangeInput with timePickerProps

Open

#3,509 opened on May 1, 2019

View on GitHub
 (2 comments) (3 reactions) (0 assignees)TypeScript (20,263 stars) (2,167 forks)batch import
Domain: APIP2Package: datetimeType: bughelp wanted

Description

Environment

  • Package version(s): @blueprintjs/core:3.15.1 @blueprintjs/datetime:3.9.0 react:16.8.6
  • Browser and OS versions: Google Chrome 74 Mozilla Firefox 66 Linux Mint 18.3

https://codesandbox.io/s/m7n7mvvoyy

Steps to reproduce

  1. In a DateRangeInput set the minDate and maxDate and use the same minDate and maxDate to supply minTime and maxTime (respectively) in said DateRangeInput's timePickerProps.
  2. Open the DateRangePicker by focusing in the input box.

Actual behavior

Notice that the times at the bottom of the DateRangePicker popover both contain the time taken from the minTime prop supplied. The time from the maxTime prop doesn't get applied.

Expected behavior

The time input on the left should contain the time extracted from the supplied minTime prop and the time input on the right should contain the time extracted from the supplied maxTime prop.

Possible solution

Contributor guide

Tech stack
reacttypescript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic knowledge of ReactUnderstanding of Blueprint's DateRangeInput component
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75
Research direction
The issue is in the DateRangeInput component where the maxTime from timePickerProps is not applied to the right (end) time picker. Investigate how timePickerProps are split and passed to the two underlying DatePicker components in the file `src/components/date time/dateRangeInput.tsx`. Look for where the time picker props are assigned to each date picker, and ensure that minTime and maxTime are correctly mapped to the start and end pickers respectively. Check the component's internal state and prop handling logic.