palantir/blueprint

Dev mode warning for Tooltip wrapping a disabled Button

Open

#3,494 opened on Apr 23, 2019

View on GitHub
 (0 comments) (2 reactions) (0 assignees)TypeScript (2,167 forks)batch import
Domain: APIP2Package: coreType: enhancementhelp wanted

Repository metrics

Stars
 (20,263 stars)
PR merge metrics
 (Avg merge 43d 10h) (27 merged PRs in 30d)

Description

Even though it's well-documented, the issue comes up frequently: https://github.com/palantir/blueprint/issues/967#issuecomment-485615346

We should log a warning in development mode, suggesting use of an AnchorButton instead. Writing a lint rule seems like it would be harder than introspecting the React tree at runtime.

cc @thelastnode

Contributor guide

Research direction
Inspect the Tooltip component's render method or useEffect to check if its child is a disabled Button component and log a warning in development mode.
Tech stack
typescriptreact
Domain
frontend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
ReactTypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75