palantir/blueprint

Tooltip support for select target

Open

#3,433 opened on Mar 20, 2019

View on GitHub
 (3 comments) (0 reactions) (0 assignees)TypeScript (2,167 forks)batch import
P3Package: corePackage: selectType: enhancementhelp wanted

Repository metrics

Stars
 (20,263 stars)
PR merge metrics
 (Avg merge 43d 10h) (27 merged PRs in 30d)

Description

Environment

  • Package version(s): core@3.14.1, select@3.7.0
  • Browser and OS versions: Chrome/MacOS

Question

Is threre a recommended way to surround the Select component target with a Tooltip? It seems like the presence of Select > Popover > Tooltip > Button does not behave exactly as the description found here.

My usage is like this:

<Select>
 <Tooltip><Button/></Tooltip>
</Select>

My own workaround is to use popoverProps to observe the select popover lifecycle:

<Select
    popoverProps={{
        onOpening: () => {
            this.setState({ isTooltipDisabled: true });
        },
        onClosed: () => {
            this.setState({ isTooltipDisabled: undefined });
        }
    }}>
    <Tooltip disabled={this.state.isTooltipDisabled}><Button/></Tooltip>
</Select>

Thanks

Contributor guide

Research direction
Investigate how to wrap a Select target with a Tooltip in Blueprint. Check existing documentation and source code for recommended patterns. Look at the Tooltip and Select component source to see if there is a built in way or if documentation needs to be improved. Consider the user's workaround and whether it can be simplified.
Tech stack
typescriptreact
Domain
frontend
Issue type
Documentation
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
ReactTypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60