palantir/blueprint

Enable strictNullChecks compiler option for all packages

Open

#325 opened on Dec 6, 2016

View on GitHub
 (9 comments) (0 reactions) (0 assignees)TypeScript (20,263 stars) (2,167 forks)batch import
Domain: toolinghelp wanted

Description

I think enabling strictNullChecks compiler option for datetime package will help us detect and prevent a whole host of potential errors, such as #322. it'll also address #274 by making the typings more accurate (as explicit null Dates actually means something in the component).

Contributor guide

Tech stack
typescriptreact
Domain
frontenddeveloper experience
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
TypeScript basicsFamiliarity with strictNullChecks
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Examine the datetime package's tsconfig.json to add 'strictNullChecks: true'. Then, compile the package to identify type errors, referring to related issues #322 and #274 for context. Fix errors by adding null checks or adjusting types, ensuring compatibility with existing code. No linked PRs or assignees exist, so work can be picked up independently.